Remove the required class from optional ssh port in installation page#5428
Merged
Conversation
the ssh port is optional during the installation process. The translations even mention that it is optional and can be blank. Right now it has the `required` class which creates the red `*` behind the field caption - used for required fields. If you leave it blank, the SSH option is disabled (not touched by this PR) Signed-off-by: Roman <romaaan.git@gmail.com>
techknowlogick
approved these changes
Nov 29, 2018
bkcsoft
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #5428 +/- ##
==========================================
- Coverage 37.55% 37.54% -0.01%
==========================================
Files 317 317
Lines 46832 46832
==========================================
- Hits 17587 17584 -3
- Misses 26744 26749 +5
+ Partials 2501 2499 -2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Nov 29, 2018
bkcsoft
added
lgtm/done
lafriks
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the ssh port is optional during the installation process. The translations even mention that it is optional and can be blank. Right now it has the
requiredclass which creates the red*behind thefield caption - used for required fields. If you leave it blank, the SSH option is disabled (not touched by this PR)